[knewstuff] /: registerServicesByCategory: add "screenshot-take"

[Gregor Mi]

Hi David,

I just commited a fix for the unit tests.

> In fact, is tests/kmoretoolstest supposed to be a unittest ?

It has both unittests and interactive dialogs in it. The interactive dialogs can be
disabled via a flag but I guess I should separate this more cleanly.

> but releasing something with broken unittests doesn't make
> me very confident.

Sorry for the trouble, it was only the unit tests that were broken.

Gregor





On 03/05/15 00:27, David Faure wrote:
> Hi Gregor, does the unittest pass for you?
> 
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastBuild/testReport/%28root%29/TestSuite/kmoretoolstest/
> 
> I get the same failures on my system.
> 
> In fact, is tests/kmoretoolstest supposed to be a unittest ? It uses qtestlib.... but then it shows
> a modal dialog (due to the call to menuBuilder->showConfigDialog(description) at line 482)
> which prevents the unittest from going further.
> 
> This should be fixed to not show a modal dialog, or to have a timer triggering the closing
> of the dialog.
> 
> I wanted to release KF 5.10 today, but releasing something with broken unittests doesn't make
> me very confident. Any chance all this can be stabilized by tomorrow?
>