[knewstuff] /: registerServicesByCategory: add "screenshot-take"

David Faure faure at kde.org
Sun May 3 08:36:43 UTC 2015


On Sunday 03 May 2015 09:11:53 Gregor Mi wrote:
> Hi David,
> 
> I just commited a fix for the unit tests.
> 
> > In fact, is tests/kmoretoolstest supposed to be a unittest ?
> 
> It has both unittests and interactive dialogs in it. The interactive dialogs
> can be disabled via a flag but I guess I should separate this more cleanly.

Yes. Also, the code is in tests/, which is the wrong place for a unittest.

The automated part of it should be in autotests/ and the interactive part of 
it should be in tests/.

Thanks for the fix :)

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list