[knewstuff] /: registerServicesByCategory: add "screenshot-take"

David Faure faure at kde.org
Sat May 2 22:27:06 UTC 2015


Hi Gregor, does the unittest pass for you?

https://build.kde.org/view/Frameworks%20kf5-qt5/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastBuild/testReport/%28root%29/TestSuite/kmoretoolstest/

I get the same failures on my system.

In fact, is tests/kmoretoolstest supposed to be a unittest ? It uses qtestlib.... but then it shows
a modal dialog (due to the call to menuBuilder->showConfigDialog(description) at line 482)
which prevents the unittest from going further.

This should be fixed to not show a modal dialog, or to have a timer triggering the closing
of the dialog.

I wanted to release KF 5.10 today, but releasing something with broken unittests doesn't make
me very confident. Any chance all this can be stabilized by tomorrow?

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list