Review Request 122682: Respect KZip::extraField setting also when writing central header entries

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122682/
-----------------------------------------------------------

(Updated March 12, 2015, 11:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit 9175940dc2e85f53621923a0fff253ec6f68e498 by Friedrich W. H. Kossebau to branch master.


Repository: karchive


Description
-------

Currently KZip when writing the central headers ignores the setting `extraField` and writes the extra fields in any case.

Not perfect. At least confuses when debugging Zip files to see that extra data present, even if explicitely not asked for. There is no hint why that is done, both in the code or could I find anything in Goo^Wthe usual search indexes services, so I assume it was just a mistake.

No unit tests this time, as I had no idea how to check that the extraFields are not written without doing errorprone seeking in the resulting file. So I just rely on the current unit tests not failing and having read the code changes 4x.


Diffs
-----

  src/kzip.cpp 73121f3 

Diff: https://git.reviewboard.kde.org/r/122682/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150312/24b95246/attachment.html>