Review Request 122682: Respect KZip::extraField setting also when writing central header entries

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122682/#review77156
-----------------------------------------------------------

Ship it!



src/kzip.cpp
<https://git.reviewboard.kde.org/r/122682/#comment53012>

    (I guess this should be & instead of ==, the day we have more than one field in that flag, but indeed the code currently uses == and we can always change it later when adding the 2nd flag.)


- David Faure


On Feb. 23, 2015, 1:11 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122682/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 1:11 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Currently KZip when writing the central headers ignores the setting `extraField` and writes the extra fields in any case.
> 
> Not perfect. At least confuses when debugging Zip files to see that extra data present, even if explicitely not asked for. There is no hint why that is done, both in the code or could I find anything in Goo^Wthe usual search indexes services, so I assume it was just a mistake.
> 
> No unit tests this time, as I had no idea how to check that the extraFields are not written without doing errorprone seeking in the resulting file. So I just rely on the current unit tests not failing and having read the code changes 4x.
> 
> 
> Diffs
> -----
> 
>   src/kzip.cpp 73121f3 
> 
> Diff: https://git.reviewboard.kde.org/r/122682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150307/7dc99fc1/attachment.html>