New framework: ModemManagerQt

David Edmundson david at davidedmundson.co.uk
Thu Mar 12 13:12:53 UTC 2015


Looks good to me.
2 minor comments.

All classes are namespaced, but generictypes.h is not.
Given these names could easily clash with something else and are publicly
included, it might be worth putting them in the same namespace.

ModemManager::ModemMessaging::messages can be const?


David

​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150312/42c5b573/attachment.html>


More information about the Kde-frameworks-devel mailing list