New framework: ModemManagerQt

[Albert Astals Cid]

El Dijous, 12 de març de 2015, a les 09:56:06, Jan Grulich va escriure:
> Hi all,
> 
> I would like to ask you if you could review ModemManagerQt library
> (currently as libmm-qt). I want to make it as framework before KF5 5.9.0
> gets released and make Plasma 5.3 depend on it, otherwise we would have to
> release it again together with Plasma and wait three more months. The only
> missing part there are unit-tests, but I'm working on them, I already added
> one yesterday and will keep adding new ones. The API is very similar to
> NetworkManagerQt, so everything mentioned during NMQT review should be
> already fixed there.
> 
> You can find it here under frameworks branch:
> https://projects.kde.org/projects/kde/workspace/libmm-qt

Kill the framework branch?

Move macros.h and mmdebug.h to _p.h?

Can listBearers and findBearer be const?

In InterfaceType i'd say you can let the enums be there even if the 
MM_CHECK_VERSION doesn't match, makes sure in case some others are added later 
they always have the same "int" value

Make BearerStruct, IpConfig and NetworkTimeZonea and the structs in 
generictypes.h classes with dptr in case you ever need more fields in them?

Add const & to params of ip4ConfigChanged, ip6ConfigChanged and 
networkTimeZoneChanged?

Cheers,
  Albert

> 
> Thanks a lot.
> 
> Regards,
> Jan