Review Request 122755: Add testcases for KIO::del()

[Martin Blumenstingl]

> On Feb. 28, 2015, 7:24 p.m., Emmanuel Pescosta wrote:
> > autotests/deldirtest.cpp, line 51
> > <https://git.reviewboard.kde.org/r/122755/diff/1/?file=352364#file352364line51>
> >
> >     KJob::NoError instead of 0?

We need a cast for that check. Maybe you can look at my solution?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/#review76769
-----------------------------------------------------------


On March 1, 2015, 12:21 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122755/
> -----------------------------------------------------------
> 
> (Updated March 1, 2015, 12:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This adds some automated testcases for KIO::del().
> 
> My own code was buggy but I didn't notice this until I wrote those tests.
> Maybe you want to have them upstream to make sure noone breaks KIO::del.
> 
> 
> Diffs
> -----
> 
>   autotests/deletejobtest.cpp PRE-CREATION 
>   autotests/CMakeLists.txt f613c1a 
>   autotests/deletejobtest.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122755/diff/
> 
> 
> Testing
> -------
> 
> Tests are passing
> 
> 
> Thanks,
> 
> Martin Blumenstingl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150301/b816e6ce/attachment.html>