Review Request 122755: Add testcases for KIO::del()

[Martin Blumenstingl]

> On March 7, 2015, 10:22 a.m., Emmanuel Pescosta wrote:
> > autotests/deletejobtest.cpp, line 62
> > <https://git.reviewboard.kde.org/r/122755/diff/3/?file=352496#file352496line62>
> >
> >     This has broken the KIO build (http://build.kde.org/job/kio_stable_qt5/123/console)
> >     
> >     QSignalSpy::QSignalSpy(const QObject * object, PointerToMemberFunction signal) is available since Qt 5.4 but KIO uses Qt 5.2
> >     
> >     Please use the old QSignalSpy::QSignalSpy(const QObject * object, const char * signal) instead
> >     
> >     This applies for all other QSignalSpy usages in this test
> 
> David Faure wrote:
>     Fixed.

Thank you both for tracking down this issue and for fixing it!


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/#review77157
-----------------------------------------------------------


On March 6, 2015, 9:57 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122755/
> -----------------------------------------------------------
> 
> (Updated March 6, 2015, 9:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This adds some automated testcases for KIO::del().
> 
> My own code was buggy but I didn't notice this until I wrote those tests.
> Maybe you want to have them upstream to make sure noone breaks KIO::del.
> 
> 
> Diffs
> -----
> 
>   autotests/deletejobtest.cpp PRE-CREATION 
>   autotests/CMakeLists.txt f613c1a 
>   autotests/deletejobtest.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122755/diff/
> 
> 
> Testing
> -------
> 
> Tests are passing
> 
> 
> Thanks,
> 
> Martin Blumenstingl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150307/ba281e59/attachment.html>