Review Request 122755: Add testcases for KIO::del()
Martin Blumenstingl
martin.blumenstingl at googlemail.com
Sun Mar 1 12:21:08 UTC 2015
> On March 1, 2015, 2:34 a.m., Aleix Pol Gonzalez wrote:
> > autotests/deletejobtest.cpp, line 43
> > <https://git.reviewboard.kde.org/r/122755/diff/2/?file=352446#file352446line43>
> >
> > Would it be better to use the unicode escaping? This can look weird in some set ups?
I also did the same for the chinese test.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/#review76790
-----------------------------------------------------------
On March 1, 2015, 12:21 p.m., Martin Blumenstingl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122755/
> -----------------------------------------------------------
>
> (Updated March 1, 2015, 12:21 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> This adds some automated testcases for KIO::del().
>
> My own code was buggy but I didn't notice this until I wrote those tests.
> Maybe you want to have them upstream to make sure noone breaks KIO::del.
>
>
> Diffs
> -----
>
> autotests/deletejobtest.cpp PRE-CREATION
> autotests/CMakeLists.txt f613c1a
> autotests/deletejobtest.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122755/diff/
>
>
> Testing
> -------
>
> Tests are passing
>
>
> Thanks,
>
> Martin Blumenstingl
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150301/b09a7973/attachment.html>
More information about the Kde-frameworks-devel
mailing list