[knewstuff] src/kmoretools: Use pimpl for KMoreToolsMenuFactory
Gregor Mi
codestruct at posteo.org
Mon Jun 1 08:22:30 UTC 2015
Am 01.06.2015 09:48 schrieb David Faure:
> On Thursday 21 May 2015 14:41:27 Gregor Mi wrote:
>> private:
>> - // Note that this object must live long enough in case the user
>> opens
>> - // the "Configure..." dialog
>> - KMoreTools* m_kmt = nullptr;
>> -
>> - QMenu* m_menu = nullptr;
>> + KMoreToolsMenuFactoryPrivate* d;
>> };
>>
>
> Err, are you changing the size of a public class after it got released?
> That would be BIC.
This should be reverted then. I'll do it. What would be good procedure
to introduce this kind of change?
More information about the Kde-frameworks-devel
mailing list