[knewstuff] src/kmoretools: Use pimpl for KMoreToolsMenuFactory

[David Faure]

On Monday 01 June 2015 10:22:19 Gregor Mi wrote:
> Am 01.06.2015 09:48 schrieb David Faure:
> > On Thursday 21 May 2015 14:41:27 Gregor Mi wrote:
> >>  private:
> >> -    // Note that this object must live long enough in case the user
> >> opens
> >> -    // the "Configure..." dialog
> >> -    KMoreTools* m_kmt = nullptr;
> >> -
> >> -    QMenu* m_menu = nullptr;
> >> +    KMoreToolsMenuFactoryPrivate* d;
> >> 
> >>  };
> > 
> > Err, are you changing the size of a public class after it got released?
> > That would be BIC.
> 
> This should be reverted then. I'll do it. What would be good procedure
> to introduce this kind of change?

If "this kind of" means a BIC, there isn't, you can't make any BICs ;)

However you could replace *one* of the two pointers with a d pointer, thereby 
preserving the object size.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5