[knewstuff] src/kmoretools: Use pimpl for KMoreToolsMenuFactory

David Faure faure at kde.org
Mon Jun 1 07:48:02 UTC 2015


On Thursday 21 May 2015 14:41:27 Gregor Mi wrote:
>  private:
> -    // Note that this object must live long enough in case the user opens
> -    // the "Configure..." dialog
> -    KMoreTools* m_kmt = nullptr;
> -
> -    QMenu* m_menu = nullptr;
> +    KMoreToolsMenuFactoryPrivate* d;
>  };
>  

Err, are you changing the size of a public class after it got released?
That would be BIC.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list