Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

[Alexander Potashev]

> On Июль 19, 2015, 10:26 п.п., Aleix Pol Gonzalez wrote:
> > Are you sure this is correct?
> > 
> > It should be: install(TARGETS ${plugin} DESTINATION ${PLUGIN_INSTALL_DIR}/kross) and then have kross only looking into that directory.

Good idea, but we'll need to extend the list of search path with the new dedicated directory, not replace it. Otherwise we break backward compatibility. (But to be fair I don't think there were some Kross/kf5 modules or language plugins released outside of KF5::Kross yet, so it may be safe to drop the former search paths.)

Regarding the choice of installation directory, I suggest it be
 1. ${KDE_INSTALL_PLUGINDIR}/kf5/kross/modules for krossmoduleforms.so and krossmodulekdetranslations.so,
 2. ${KDE_INSTALL_PLUGINDIR}/kf5/kross/interpreters for krossqts.so (and for krosspython.so from package kross-interpreters).

krossqtsplugin.so needs to stay in ${KDE_INSTALL_QTPLUGINDIR}/script because Kross is not responsible for loading it.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124398/#review82672
-----------------------------------------------------------


On Июль 19, 2015, 8:37 п.п., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124398/
> -----------------------------------------------------------
> 
> (Updated Июль 19, 2015, 8:37 п.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> All shared libraries (including modules) are loaded by KrossCore with
> the use of QLibrary and searched in paths returned by
> QCoreApplication::libraryPaths(). QCoreApplication::libraryPaths()
> includes <qt-install-dir>/plugins, therefore KDE_INSTALL_QTPLUGINDIR is
> the right place to install Kross modules.
> 
> 
> Diffs
> -----
> 
>   src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 
> 
> Diff: https://git.reviewboard.kde.org/r/124398/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150719/31894ca8/attachment.html>