Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124398/#review82672
-----------------------------------------------------------


Are you sure this is correct?

It should be: install(TARGETS ${plugin} DESTINATION ${PLUGIN_INSTALL_DIR}/kross) and then have kross only looking into that directory.

- Aleix Pol Gonzalez


On July 19, 2015, 10:37 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124398/
> -----------------------------------------------------------
> 
> (Updated July 19, 2015, 10:37 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> All shared libraries (including modules) are loaded by KrossCore with
> the use of QLibrary and searched in paths returned by
> QCoreApplication::libraryPaths(). QCoreApplication::libraryPaths()
> includes <qt-install-dir>/plugins, therefore KDE_INSTALL_QTPLUGINDIR is
> the right place to install Kross modules.
> 
> 
> Diffs
> -----
> 
>   src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 
> 
> Diff: https://git.reviewboard.kde.org/r/124398/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150719/5ea7da72/attachment.html>