<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124398/">https://git.reviewboard.kde.org/r/124398/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Июль 19th, 2015, 10:26 п.п. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Are you sure this is correct?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It should be: install(TARGETS ${plugin} DESTINATION ${PLUGIN_INSTALL_DIR}/kross) and then have kross only looking into that directory.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good idea, but we'll need to extend the list of search path with the new dedicated directory, not replace it. Otherwise we break backward compatibility. (But to be fair I don't think there were some Kross/kf5 modules or language plugins released outside of KF5::Kross yet, so it may be safe to drop the former search paths.)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding the choice of installation directory, I suggest it be
1. ${KDE_INSTALL_PLUGINDIR}/kf5/kross/modules for krossmoduleforms.so and krossmodulekdetranslations.so,
2. ${KDE_INSTALL_PLUGINDIR}/kf5/kross/interpreters for krossqts.so (and for krosspython.so from package kross-interpreters).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">krossqtsplugin.so needs to stay in ${KDE_INSTALL_QTPLUGINDIR}/script because Kross is not responsible for loading it.</p></pre>
<br />
<p>- Alexander</p>
<br />
<p>On Июль 19th, 2015, 8:37 п.п. UTC, Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated Июль 19, 2015, 8:37 п.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kross
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All shared libraries (including modules) are loaded by KrossCore with
the use of QLibrary and searched in paths returned by
QCoreApplication::libraryPaths(). QCoreApplication::libraryPaths()
includes <qt-install-dir>/plugins, therefore KDE_INSTALL_QTPLUGINDIR is
the right place to install Kross modules.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/modules/CMakeLists.txt <span style="color: grey">(48e2c0219072b1b1335821b0290d261d8dc3d361)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124398/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>