Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

[Alexander Potashev]

> On Июль 19, 2015, 8:52 п.п., Albert Astals Cid wrote:
> > Does this break co-installability with kdelibs4 based kross-plugins?

No, it doesn't, unless it was broken already in some distributions.

Given the distro uses separate installation paths for Qt5 and Qt4, the these plugins will go into /usr/lib/qt5/plugins/.

If there was a distro that installs all plugins in one place, then it would fail before this patch because krossqts.so (which is already being installed in ${KDE_INSTALL_QTPLUGINDIR}) from kross-5.x and kdelibs/kross-4.x had to collide.

For most distributions both KDE_INSTALL_QTPLUGINDIR and KDE_INSTALL_PLUGINDIR are set to /usr/lib/qt5/plugins, so this patch has no effect on them.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124398/#review82666
-----------------------------------------------------------


On Июль 19, 2015, 8:37 п.п., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124398/
> -----------------------------------------------------------
> 
> (Updated Июль 19, 2015, 8:37 п.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> All shared libraries (including modules) are loaded by KrossCore with
> the use of QLibrary and searched in paths returned by
> QCoreApplication::libraryPaths(). QCoreApplication::libraryPaths()
> includes <qt-install-dir>/plugins, therefore KDE_INSTALL_QTPLUGINDIR is
> the right place to install Kross modules.
> 
> 
> Diffs
> -----
> 
>   src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 
> 
> Diff: https://git.reviewboard.kde.org/r/124398/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150719/08afdab4/attachment.html>