Review Request 124371: Fix potential endless recursion in PlatformStatus::findLookAndFeelPackage()
Daniel Vrátil
dvratil at kde.org
Thu Jul 16 11:38:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124371/
-----------------------------------------------------------
Review request for KDE Frameworks and Marco Martin.
Repository: plasma-framework
Description
-------
The `LookAndFeel` entry does not exist in `kdeglobals` (it's called `LookAndFeelPackage`), so when the configured LnF package is removed or renamed, the code will go to endless loop because it never clears the configuration ine `kdeglobals` correctly.
We discovered this in Fedora, because we ship our own ugly LnF package, and we renamed it at some point, which caused KDED to go nuts.
Diffs
-----
src/platformstatus/platformstatus.cpp e03c16d
Diff: https://git.reviewboard.kde.org/r/124371/diff/
Testing
-------
Thanks,
Daniel Vrátil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150716/b5bcd017/attachment.html>
More information about the Kde-frameworks-devel
mailing list