Review Request 124371: Fix potential endless recursion in PlatformStatus::findLookAndFeelPackage()

Bhushan Shah bhush94 at gmail.com
Thu Jul 16 12:49:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124371/#review82566
-----------------------------------------------------------


+1, though I remember sebas also tried to fix some recursive loop here sometime ago..

tree b2e50f720e779924ffbc9211c935cb433894337a                                                                                                                                                     
parent 2d7dfd214789ec140306eb18971689909692deae                                                                                                                                                   
author Sebastian Kügler <sebas at kde.org> Thu Jan 29 13:35:31 2015 +0100                                                                                                                            
committer Sebastian Kügler <sebas at kde.org> Thu Jan 29 13:35:31 2015 +0100                                                                                                                         
                                                                                                                                                                                                  
Fix fallback from invalid L&F packages                                                                                                                                                            
                                                                                                                                                                                                  
The mechanism should have deleted the old key from the config if it was                                                                                                                           
invalid and then try again in order to get the default. As we were                                                                                                                                
deleting the wrong key (actually the value of the shell package key),                                                                                                                             
this was turning into a recursive loop. Deleting the correct key                                                                                                                                  
obviously fixes this.                                                                                                                                                                             
                                                                                                                                                                                                  
Thanks Bille for reporting!                                                                                                                                                                       
                                                                                                                                                                                                  
Reviewed-by: Marco Martin                                                                                                                                                                         
                                                                                                                                                                                                  
BUG:343510

- Bhushan Shah


On July 16, 2015, 5:08 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124371/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 5:08 p.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> The `LookAndFeel` entry does not exist in `kdeglobals` (it's called `LookAndFeelPackage`), so when the configured LnF package is removed or renamed, the code will go to endless loop because it never clears the configuration ine `kdeglobals` correctly.
> 
> We discovered this in Fedora, because we ship our own ugly LnF package, and we renamed it at some point, which caused KDED to go nuts.
> 
> 
> Diffs
> -----
> 
>   src/platformstatus/platformstatus.cpp e03c16d 
> 
> Diff: https://git.reviewboard.kde.org/r/124371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150716/9526de47/attachment.html>


More information about the Kde-frameworks-devel mailing list