Review Request 124150: Fix KCoreAddons build on Clang+ARM

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jul 15 15:27:48 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124150/
-----------------------------------------------------------

(Updated July 15, 2015, 3:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Rohan Garg.


Changes
-------

Submitted with commit 05e5dfacb3c747774728124280b4646a6da9e0be by Aleix Pol to branch master.


Repository: kcoreaddons


Description
-------

Tries to address the issue pointed out by Rohan.

We have a set of reverse-engineered literals and one of them we're specifying it as unsigned (the rest are smaller, so it doesn't make a difference), even though the API returns a signed int.


Diffs
-----

  src/lib/io/kfilesystemtype.cpp e4043e4 

Diff: https://git.reviewboard.kde.org/r/124150/diff/


Testing
-------

Still compiles in the comfortable amd64+g++.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150715/db8e55f0/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list