Review Request 124306: Don't choke on empty QIconItem

[Aleix Pol Gonzalez]

> On July 13, 2015, 12:49 p.m., David Edmundson wrote:
> > it would be more performant to delete the node if it's empty.
> > 
> > though this is still fine.

If I return a null node, I get such a crash:

```
#0 QSGTexture::setFiltering() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/util/qsgtexture.cpp:444
#1 QSGOpaqueTextureMaterialShader::updateState() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/util/qsgtexturematerial.cpp:81
#2 QSGBatchRenderer::Renderer::renderMergedBatch() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgbatchrenderer.cpp:2263
#3 QSGBatchRenderer::Renderer::renderBatches() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgbatchrenderer.cpp:2486
#4 QSGBatchRenderer::Renderer::render() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgbatchrenderer.cpp:2674
#5 QSGRenderer::renderScene() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgrenderer.cpp:208
#6 QSGRenderer::renderScene() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgrenderer.cpp:161
#7 QSGRenderContext::renderNextFrame() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/qsgcontext.cpp:558
#8 QQuickWindowPrivate::renderSceneGraph() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/items/qquickwindow.cpp:383
#9 QQuickRenderControl::render() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/items/qquickrendercontrol.cpp:309
#10 QQuickWidgetPrivate::render() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quickwidgets/qquickwidget.cpp:217
#11 QQuickWidgetPrivate::renderSceneGraph() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quickwidgets/qquickwidget.cpp:244
```


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124306/#review82278
-----------------------------------------------------------


On July 9, 2015, 4:07 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124306/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Sometimes QML components have 0 width and height and that's perfectly fine.
> 
> If we try to paint it, we get warnings such as:
> `QPainter::begin: Paint device returned engine == 0, type: 2`
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 
> 
> Diff: https://git.reviewboard.kde.org/r/124306/diff/
> 
> 
> Testing
> -------
> 
> Fixes the issue in muon-discover, doesn't break tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150715/210d4f83/attachment.html>