<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124306/">https://git.reviewboard.kde.org/r/124306/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 13th, 2015, 12:49 p.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it would be more performant to delete the node if it's empty.
though this is still fine.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I return a null node, I get such a crash:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">#0 QSGTexture::setFiltering() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/util/qsgtexture.cpp:444
#1 QSGOpaqueTextureMaterialShader::updateState() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/util/qsgtexturematerial.cpp:81
#2 QSGBatchRenderer::Renderer::renderMergedBatch() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgbatchrenderer.cpp:2263
#3 QSGBatchRenderer::Renderer::renderBatches() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgbatchrenderer.cpp:2486
#4 QSGBatchRenderer::Renderer::render() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgbatchrenderer.cpp:2674
#5 QSGRenderer::renderScene() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgrenderer.cpp:208
#6 QSGRenderer::renderScene() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgrenderer.cpp:161
#7 QSGRenderContext::renderNextFrame() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/scenegraph/qsgcontext.cpp:558
#8 QQuickWindowPrivate::renderSceneGraph() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/items/qquickwindow.cpp:383
#9 QQuickRenderControl::render() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/items/qquickrendercontrol.cpp:309
#10 QQuickWidgetPrivate::render() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quickwidgets/qquickwidget.cpp:217
#11 QQuickWidgetPrivate::renderSceneGraph() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quickwidgets/qquickwidget.cpp:244
</pre></div>
</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On July 9th, 2015, 4:07 p.m. CEST, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated July 9, 2015, 4:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sometimes QML components have 0 width and height and that's perfectly fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If we try to paint it, we get warnings such as:
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QPainter::begin: Paint device returned engine == 0, type: 2</code></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixes the issue in muon-discover, doesn't break tests.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp <span style="color: grey">(3a9dd17)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124306/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>