Review Request 124306: Don't choke on empty QIconItem

Wed Jul 15 15:24:59 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124306/
-----------------------------------------------------------

(Updated July 15, 2015, 3:24 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Changes
-------

Submitted with commit 78b455d447c14d782b8a7fcf01ea122a98f40edc by Aleix Pol to branch master.

Repository: kdeclarative

Description
-------

Sometimes QML components have 0 width and height and that's perfectly fine.

If we try to paint it, we get warnings such as:
`QPainter::begin: Paint device returned engine == 0, type: 2`

Diffs
-----

  src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 

Diff: https://git.reviewboard.kde.org/r/124306/diff/

Testing
-------

Fixes the issue in muon-discover, doesn't break tests.

Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150715/0eb012b5/attachment.html>