Review Request 124306: Don't choke on empty QIconItem
Mark Gaiser
markg85 at gmail.com
Thu Jul 9 14:22:37 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124306/#review82271
-----------------------------------------------------------
src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp (line 137)
<https://git.reviewboard.kde.org/r/124306/#comment56650>
(nitpick) a missing sace.
img = m_...
+1
- Mark Gaiser
On jul 9, 2015, 2:07 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124306/
> -----------------------------------------------------------
>
> (Updated jul 9, 2015, 2:07 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Sometimes QML components have 0 width and height and that's perfectly fine.
>
> If we try to paint it, we get warnings such as:
> `QPainter::begin: Paint device returned engine == 0, type: 2`
>
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17
>
> Diff: https://git.reviewboard.kde.org/r/124306/diff/
>
>
> Testing
> -------
>
> Fixes the issue in muon-discover, doesn't break tests.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150709/76b0522a/attachment.html>
More information about the Kde-frameworks-devel
mailing list