Review Request 124306: Don't choke on empty QIconItem

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jul 9 14:07:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124306/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdeclarative


Description
-------

Sometimes QML components have 0 width and height and that's perfectly fine.

If we try to paint it, we get warnings such as:
`QPainter::begin: Paint device returned engine == 0, type: 2`


Diffs
-----

  src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 

Diff: https://git.reviewboard.kde.org/r/124306/diff/


Testing
-------

Fixes the issue in muon-discover, doesn't break tests.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150709/ae2290b2/attachment.html>


More information about the Kde-frameworks-devel mailing list