Review Request 124306: Don't choke on empty QIconItem

[Mark Gaiser]

> On jul 9, 2015, 2:22 p.m., Mark Gaiser wrote:
> > src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp, line 138
> > <https://git.reviewboard.kde.org/r/124306/diff/1/?file=383903#file383903line138>
> >
> >     (nitpick) a missing sace.
> >     img = m_...

space*


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124306/#review82271
-----------------------------------------------------------


On jul 9, 2015, 2:07 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124306/
> -----------------------------------------------------------
> 
> (Updated jul 9, 2015, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Sometimes QML components have 0 width and height and that's perfectly fine.
> 
> If we try to paint it, we get warnings such as:
> `QPainter::begin: Paint device returned engine == 0, type: 2`
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 
> 
> Diff: https://git.reviewboard.kde.org/r/124306/diff/
> 
> 
> Testing
> -------
> 
> Fixes the issue in muon-discover, doesn't break tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150709/6b1a9d34/attachment.html>