Review Request 126481: Avoid deliberately overflowing a full buffer.

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126481/#review90120
-----------------------------------------------------------

Ship it!


Minor coding style nitpick, please fix before committing. Thanks!


src/kcodecs.cpp (line 721)
<https://git.reviewboard.kde.org/r/126481/#comment61730>

    Move the "else {" to this line.


- Daniel Vrátil


On Dec. 23, 2015, 3:50 a.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126481/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 3:50 a.m.)
> 
> 
> Review request for KDE Frameworks and Daniel Vrátil.
> 
> 
> Repository: kcodecs
> 
> 
> Description
> -------
> 
> Subject says it all. If we're going to note that a buffer is overflowing, we can at least avoid overflowing it.
> 
> Of course ignoring the error is just as bad but it's at least "defined behavior" bad.
> 
> 
> Diffs
> -----
> 
>   src/kcodecs.cpp 9efcad8 
> 
> Diff: https://git.reviewboard.kde.org/r/126481/diff/
> 
> 
> Testing
> -------
> 
> Compiles. codectest and rfc2047test still pass, though I'm honestly not sure how much of this codepath they might exercise.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151226/838999a1/attachment.html>