Review Request 126481: Avoid deliberately overflowing a full buffer.

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126481/
-----------------------------------------------------------

(Updated Dec. 26, 2015, 4:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Daniel Vrátil.


Changes
-------

Submitted with commit 543cbd6d2a02b82ad7832d26a01fcfeaca7898b7 by Michael Pyne to branch master.


Repository: kcodecs


Description
-------

Subject says it all. If we're going to note that a buffer is overflowing, we can at least avoid overflowing it.

Of course ignoring the error is just as bad but it's at least "defined behavior" bad.


Diffs
-----

  src/kcodecs.cpp 9efcad8 

Diff: https://git.reviewboard.kde.org/r/126481/diff/


Testing
-------

Compiles. codectest and rfc2047test still pass, though I'm honestly not sure how much of this codepath they might exercise.


Thanks,

Michael Pyne

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151226/a1b23348/attachment.html>