Review Request 126481: Avoid deliberately overflowing a full buffer.

Michael Pyne mpyne at kde.org
Wed Dec 23 02:50:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126481/
-----------------------------------------------------------

Review request for KDE Frameworks and Daniel Vrátil.


Repository: kcodecs


Description
-------

Subject says it all. If we're going to note that a buffer is overflowing, we can at least avoid overflowing it.

Of course ignoring the error is just as bad but it's at least "defined behavior" bad.


Diffs
-----

  src/kcodecs.cpp 9efcad8 

Diff: https://git.reviewboard.kde.org/r/126481/diff/


Testing
-------

Compiles. codectest and rfc2047test still pass, though I'm honestly not sure how much of this codepath they might exercise.


Thanks,

Michael Pyne

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151223/b0c51c5e/attachment.html>


More information about the Kde-frameworks-devel mailing list