Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

[Kevin Funk]

> On Aug. 24, 2015, 12:15 p.m., Kevin Funk wrote:
> > More context:
> > 
> > ```
> > [5748] klauncher not running... launching kdeinit
> > [6344] kf5.kinit.klauncher: LAUNCHER_OK
> > [2892] Could not find drkonqi at Z:/kderoot/bin/drkonqi
> > [2892] QObject::connect: No such signal UrlHandler::destroyed(QObject*)
> > [6344] kf5.kinit.klauncher: "Z:/kderoot/bin/kbuildsycoca5.exe" (pid 1780) up and running.
> > [1780] Could not find drkonqi at Z:/kderoot/bin/drkonqi
> > [1780] kf5.kservice.sycoca: Trying to open ksycoca from "C:/Users/kfunk/AppData/Local/cache/ksycoca5"
> > [1780] checking file timestamps
> > [1780] timestamps check ok
> > [1780] Emitting notifyDatabaseChanged ()
> > [6344] kf5.kinit.klauncher: kbuildsycoca5 running... 
> > [6344] 
> > [6344] kf5.kinit.klauncher: process finished exitcode= 0 exitStatus= 0
> > [2892] kf5.kservice.sycoca: Trying to open ksycoca from "C:/Users/kfunk/AppData/Local/cache/ksycoca5"
> > [2892] kf5.kservice.sycoca: checking file timestamps
> > [2892] kf5.kservice.sycoca: timestamp changed: "Z:/kderoot/bin/../share/kservicetypes5"
> > [6100] Could not find drkonqi at Z:/kderoot/bin/drkonqi
> > [6100] kf5.kservice.sycoca: Trying to open ksycoca from "C:/Users/kfunk/AppData/Local/cache/ksycoca5"
> > [6100] Reusing existing ksycoca
> > [6100] Recreating ksycoca file ("C:/Users/kfunk/AppData/Local/cache/ksycoca5", version 302)
> > [6344] kf5.kinit.klauncher: KLauncher: launching new slave "Z:/kderoot/bin/kioslave" with protocol= "file" args= ("Z:/kderoot/lib/plugins/kf5/kio/file.dll", "file", "tcp://127.0.0.1:56480", "tcp://127.0.0.1:56477")
> > [6344] kf5.kinit.klauncher: "Z:/kderoot/bin/kioslave" (pid 4568) up and running.
> > [4568] trying to load "Z:/kderoot/lib/plugins/kf5/kio/file.dll" from "Z:/kderoot/lib/plugins/kf5/kio/file.dll"
> > ```

Oh, and I just noticed KDE_FORK_SLAVES=1 doesn't really help on Windows. That whole feature is wrapped with a big fat `#ifdef Q_OS_UNIX`...


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124876/#review84272
-----------------------------------------------------------


On Aug. 22, 2015, 10:45 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124876/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2015, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks, Boudewijn Rempt and Vishesh Handa.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> If 1.5s have passed since the last time we checked, we compare the mtime of
> the directories (12 dirs on my system) with the timestamp stored in the
> ksycoca database (which indicates that all changes prior to that time
> are in the DB).
> 
> Note that we only check the mtime of dirs, not files. Therefore manually
> editing an installed .desktop file will require touching the dir, or
> running kbuildsycoca5.
> 
> 
> Diffs
> -----
> 
>   src/sycoca/ksycoca.cpp b7f7abc88db90d784851d91036069e0647fdcbf6 
>   src/sycoca/ksycoca_p.h 9f403d6f4be2b406f4985f668176cfa56a5898ea 
> 
> Diff: https://git.reviewboard.kde.org/r/124876/diff/
> 
> 
> Testing
> -------
> 
> the kservice unittests still pass
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150824/b78a3f04/attachment.html>