Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124876/
-----------------------------------------------------------

(Updated Aug. 28, 2015, 9:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Boudewijn Rempt and Vishesh Handa.


Changes
-------

Submitted with commit 1d7eb96791ae385b05c0fa5c2363902741489e1b by David Faure to branch master.


Repository: kservice


Description
-------

If 1.5s have passed since the last time we checked, we compare the mtime of
the directories (12 dirs on my system) with the timestamp stored in the
ksycoca database (which indicates that all changes prior to that time
are in the DB).

Note that we only check the mtime of dirs, not files. Therefore manually
editing an installed .desktop file will require touching the dir, or
running kbuildsycoca5.


Diffs
-----

  src/sycoca/ksycoca.cpp b7f7abc88db90d784851d91036069e0647fdcbf6 
  src/sycoca/ksycoca_p.h 9f403d6f4be2b406f4985f668176cfa56a5898ea 

Diff: https://git.reviewboard.kde.org/r/124876/diff/


Testing
-------

the kservice unittests still pass


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150828/93b75314/attachment.html>