<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124876/">https://git.reviewboard.kde.org/r/124876/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 24th, 2015, 12:15 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">More context:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">[5748] klauncher not running... launching kdeinit
[6344] kf5.kinit.klauncher: LAUNCHER_OK
[2892] Could not find drkonqi at Z:/kderoot/bin/drkonqi
[2892] QObject::connect: No such signal UrlHandler::destroyed(QObject*)
[6344] kf5.kinit.klauncher: "Z:/kderoot/bin/kbuildsycoca5.exe" (pid 1780) up and running.
[1780] Could not find drkonqi at Z:/kderoot/bin/drkonqi
[1780] kf5.kservice.sycoca: Trying to open ksycoca from "C:/Users/kfunk/AppData/Local/cache/ksycoca5"
[1780] checking file timestamps
[1780] timestamps check ok
[1780] Emitting notifyDatabaseChanged ()
[6344] kf5.kinit.klauncher: kbuildsycoca5 running...
[6344]
[6344] kf5.kinit.klauncher: process finished exitcode= 0 exitStatus= 0
[2892] kf5.kservice.sycoca: Trying to open ksycoca from "C:/Users/kfunk/AppData/Local/cache/ksycoca5"
[2892] kf5.kservice.sycoca: checking file timestamps
[2892] kf5.kservice.sycoca: timestamp changed: "Z:/kderoot/bin/../share/kservicetypes5"
[6100] Could not find drkonqi at Z:/kderoot/bin/drkonqi
[6100] kf5.kservice.sycoca: Trying to open ksycoca from "C:/Users/kfunk/AppData/Local/cache/ksycoca5"
[6100] Reusing existing ksycoca
[6100] Recreating ksycoca file ("C:/Users/kfunk/AppData/Local/cache/ksycoca5", version 302)
[6344] kf5.kinit.klauncher: KLauncher: launching new slave "Z:/kderoot/bin/kioslave" with protocol= "file" args= ("Z:/kderoot/lib/plugins/kf5/kio/file.dll", "file", "tcp://127.0.0.1:56480", "tcp://127.0.0.1:56477")
[6344] kf5.kinit.klauncher: "Z:/kderoot/bin/kioslave" (pid 4568) up and running.
[4568] trying to load "Z:/kderoot/lib/plugins/kf5/kio/file.dll" from "Z:/kderoot/lib/plugins/kf5/kio/file.dll"
</pre></div>
</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh, and I just noticed KDE_FORK_SLAVES=1 doesn't really help on Windows. That whole feature is wrapped with a big fat <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">#ifdef Q_OS_UNIX</code>...</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On August 22nd, 2015, 10:45 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Boudewijn Rempt and Vishesh Handa.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Aug. 22, 2015, 10:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If 1.5s have passed since the last time we checked, we compare the mtime of
the directories (12 dirs on my system) with the timestamp stored in the
ksycoca database (which indicates that all changes prior to that time
are in the DB).
Note that we only check the mtime of dirs, not files. Therefore manually
editing an installed .desktop file will require touching the dir, or
running kbuildsycoca5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the kservice unittests still pass</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(b7f7abc88db90d784851d91036069e0647fdcbf6)</span></li>
<li>src/sycoca/ksycoca_p.h <span style="color: grey">(9f403d6f4be2b406f4985f668176cfa56a5898ea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124876/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>