Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123414/#review79543
-----------------------------------------------------------

Ship it!


You can apply this to kdelibs4 too, after backporting it (it won't be toDisplayString() there, check what the code does and do the same). You can push to both.

- David Faure


On April 26, 2015, 7:12 p.m., Anthony Vital wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123414/
> -----------------------------------------------------------
> 
> (Updated April 26, 2015, 7:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Apparently this hasn't been working for a long time.
> 
> Also, the code seems to duplicate an entry on purpose if a file was opened twice but with two different applications. I don't understand why this is desirable. Wouldn't it be better if the old entry was just updated?
> 
> 
> Diffs
> -----
> 
>   src/core/krecentdocument.cpp d95733d804a766cd740540d3db9cff2cb94bf140 
> 
> Diff: https://git.reviewboard.kde.org/r/123414/diff/
> 
> 
> Testing
> -------
> 
> Created two files with the same name but in different places, opened them. Two entries with different URLs are created.
> 
> 
> Thanks,
> 
> Anthony Vital
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150426/30f20c5d/attachment.html>