Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.
Anthony Vital
anthony.vital at gmail.com
Sun Apr 26 19:12:58 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123414/
-----------------------------------------------------------
(Updated avr. 26, 2015, 7:12 après-midi)
Review request for KDE Frameworks.
Changes
-------
Changed to what was suggested
Repository: kio
Description
-------
Apparently this hasn't been working for a long time.
Also, the code seems to duplicate an entry on purpose if a file was opened twice but with two different applications. I don't understand why this is desirable. Wouldn't it be better if the old entry was just updated?
Diffs (updated)
-----
src/core/krecentdocument.cpp d95733d804a766cd740540d3db9cff2cb94bf140
Diff: https://git.reviewboard.kde.org/r/123414/diff/
Testing
-------
Created two files with the same name but in different places, opened them. Two entries with different URLs are created.
Thanks,
Anthony Vital
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150426/4cc9d0b7/attachment.html>
More information about the Kde-frameworks-devel
mailing list