Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.

[Anthony Vital]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123414/
-----------------------------------------------------------

(Updated April 27, 2015, 7:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit e47caf3b1739e65e494a906fdc7780384e4395f5 by Anthony Vital to branch master.


Repository: kio


Description
-------

Apparently this hasn't been working for a long time.

Also, the code seems to duplicate an entry on purpose if a file was opened twice but with two different applications. I don't understand why this is desirable. Wouldn't it be better if the old entry was just updated?


Diffs
-----

  src/core/krecentdocument.cpp d95733d804a766cd740540d3db9cff2cb94bf140 

Diff: https://git.reviewboard.kde.org/r/123414/diff/


Testing
-------

Created two files with the same name but in different places, opened them. Two entries with different URLs are created.


Thanks,

Anthony Vital

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150427/835ebe19/attachment.html>