Review Request 123443: Make it possible to call a put job from an IODevice

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123443/#review79515
-----------------------------------------------------------


I love the idea (QIODevice rocks). But I wonder about the naming. "Store" was because the data is stored in a QByteArray rather than provided in chunks.

But with QIODevice the data might be read incrementally from somewhere (e.g. a file). So it's not really stored into a big memory buffer.

So I think this should be a KIO::put() overload. (Or maybe a different name for easier searching, but putIODevice or putFromIODevice isn't great.)

- David Faure


On April 22, 2015, 4:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123443/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 4:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Also adopts it when using KIO::AccessManager::put. Otherwise it was doing a ::readAll and then passed the QByteArray around, which isn't very elegant.
> 
> 
> Diffs
> -----
> 
>   autotests/accessmanagertest.cpp 5e4988f 
>   autotests/jobtest.h ef0ec57 
>   autotests/jobtest.cpp b11e9f9 
>   src/core/storedtransferjob.h d3e1106 
>   src/core/storedtransferjob.cpp 7f81d00 
>   src/widgets/accessmanager.cpp 239281e 
> 
> Diff: https://git.reviewboard.kde.org/r/123443/diff/
> 
> 
> Testing
> -------
> 
> New test for the new method.
> Tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150425/98bbbadb/attachment.html>