Review Request 123443: Make it possible to call a put job from an IODevice

David Faure faure at kde.org
Sat Apr 25 20:26:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123443/#review79516
-----------------------------------------------------------


Hmm but this returns a StoredTransferJob because TransferJob only knows to emit signals.... hmm. scratch what I said then, I guess.

- David Faure


On April 22, 2015, 4:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123443/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 4:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Also adopts it when using KIO::AccessManager::put. Otherwise it was doing a ::readAll and then passed the QByteArray around, which isn't very elegant.
> 
> 
> Diffs
> -----
> 
>   autotests/accessmanagertest.cpp 5e4988f 
>   autotests/jobtest.h ef0ec57 
>   autotests/jobtest.cpp b11e9f9 
>   src/core/storedtransferjob.h d3e1106 
>   src/core/storedtransferjob.cpp 7f81d00 
>   src/widgets/accessmanager.cpp 239281e 
> 
> Diff: https://git.reviewboard.kde.org/r/123443/diff/
> 
> 
> Testing
> -------
> 
> New test for the new method.
> Tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150425/94c521d4/attachment.html>


More information about the Kde-frameworks-devel mailing list