Review Request 123443: Make it possible to call a put job from an IODevice
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Apr 22 16:13:47 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123443/
-----------------------------------------------------------
(Updated April 22, 2015, 6:13 p.m.)
Review request for KDE Frameworks.
Changes
-------
Fix unit test as pointed out by Albert Vaca, still passes.
Repository: kio
Description
-------
Also adopts it when using KIO::AccessManager::put. Otherwise it was doing a ::readAll and then passed the QByteArray around, which isn't very elegant.
Diffs (updated)
-----
autotests/accessmanagertest.cpp 5e4988f
autotests/jobtest.h ef0ec57
autotests/jobtest.cpp b11e9f9
src/core/storedtransferjob.h d3e1106
src/core/storedtransferjob.cpp 7f81d00
src/widgets/accessmanager.cpp 239281e
Diff: https://git.reviewboard.kde.org/r/123443/diff/
Testing
-------
New test for the new method.
Tests still pass.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150422/ea48340c/attachment.html>
More information about the Kde-frameworks-devel
mailing list