New framework: KF5Syndication

[Daniel Vrátil]

On Wednesday, April 22, 2015 10:51:15 PM Mark Gaiser wrote:
> On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil <dvratil at kde.org> wrote:
> > Hi all,
> > 
> > I'd like to ask for review of another Framework from kdepimlibs:
> > KF5Syndication
> > 
> > KF5Syndication is an RSS/Atom parsing library. It also provides API to
> > fetch
> > feeds directly from network.
> > 
> > It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's currently
> > being
> > used only by Akregator.
> > 
> > I would like to submit KF5Syndication for the standard 2 week review
> > period, and if everything is OK, then move it to Frameworks.
> > 
> > Cheers,
> > Daniel
> > 
> > Disclaimer: I've never seen this code nor knew about it's existence till
> 
> ~30 minutes ago.
> 
> This library depends on QtXml (quite heavily in fact). That very Qt module
> is deprecated [1].
> Funnily enough, that is the only place that mentions it as being
> deprecated. No QtXml classes mention it in the docs and you won't get any
> compiler warnings either when you decide to use it.
> 
> When searching for bug reports for deprecating QtXml i found [2] where they
> say it's been mislabeled and should have the same status as Widgets. Aka:
> done.
> Which also means it might go deprecated in some future release (Qt6?).
> 
> Now i don't know what the real state of QtXml is, but if it really is
> deprecated then i don't know if it's wise to release this library while
> depending on a deprecated module.
> In that case it might be better to "port" (which probably requires quite
> some work) to the QXmlStreamReader and QXmlStreamWriter.

I don't think we need to bother ourselves with this now since QtXml is not 
going away in Qt 5. If QtXml is indeed removed from Qt at some point then we 
will of course have to re-evaluate switching to QXmlStreamReader (or  some 3rd 
party parser). QtXml is not exposed in public API of Syndication, so we should 
be able to just switch to different parser in KF6 without breaking API (too 
much).

QXmlStreamReader has a rather low-level API IMO - it's OK if you want to parse 
the XML top-down but what Syndication does is closer to mapping objects to 
parts of the XML DOM so as you said rewriting it to QXmlStreamReader would be 
quite a lot of work.

Cheers,
Dan

> 
> Just my 5 cents :)
> 
> [1] http://doc.qt.io/qt-5/qtmodules.html
> [2] https://bugreports.qt.io/browse/QTBUG-32926

-- 
Daniel Vrátil
www.dvratil.cz | dvratil at kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150422/287b4017/attachment-0001.sig>