Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Apr 22 16:07:40 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
-----------------------------------------------------------
(Updated April 22, 2015, 6:07 p.m.)
Review request for KDE Frameworks and Matthew Dawson.
Changes
-------
* Create a different kind of signal that will be generated whenever the set method is called for a property, in contrast to whenever it's written to disk.
* Don't consider properties as modified if the same value is set.
Repository: kconfig
Description
-------
The generation of those classes makes it useful to have these being used within C++ application. This change makes it possible to use these classes from QML as well.
For each variable, exposes the getter. In case there's a setter, it will add a notify signal and the setter to the property.
Diffs (updated)
-----
autotests/kconfig_compiler/CMakeLists.txt 0cca605
autotests/kconfig_compiler/kconfigcompiler_test.cpp 43623ce
autotests/kconfig_compiler/test13.cpp.ref PRE-CREATION
autotests/kconfig_compiler/test13.h.ref PRE-CREATION
autotests/kconfig_compiler/test13.kcfg PRE-CREATION
autotests/kconfig_compiler/test13.kcfgc PRE-CREATION
autotests/kconfig_compiler/test13main.cpp PRE-CREATION
autotests/kconfig_compiler/test_signal.cpp.ref 58e73ef
autotests/kconfig_compiler/test_signal.h.ref 19b8b40
src/kconfig_compiler/kconfig_compiler.cpp 5aae340
Diff: https://git.reviewboard.kde.org/r/123367/diff/
Testing
-------
KConfig tests still pass.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150422/a3c703cc/attachment.html>
More information about the Kde-frameworks-devel
mailing list