<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123367/">https://git.reviewboard.kde.org/r/123367/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated April 22, 2015, 6:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Create a different kind of signal that will be generated whenever the set method is called for a property, in contrast to whenever it's written to disk.
* Don't consider properties as modified if the same value is set.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The generation of those classes makes it useful to have these being used within C++ application. This change makes it possible to use these classes from QML as well.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For each variable, exposes the getter. In case there's a setter, it will add a notify signal and the setter to the property.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KConfig tests still pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconfig_compiler/CMakeLists.txt <span style="color: grey">(0cca605)</span></li>
<li>autotests/kconfig_compiler/kconfigcompiler_test.cpp <span style="color: grey">(43623ce)</span></li>
<li>autotests/kconfig_compiler/test13.cpp.ref <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test13.h.ref <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test13.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test13.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test13main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test_signal.cpp.ref <span style="color: grey">(58e73ef)</span></li>
<li>autotests/kconfig_compiler/test_signal.h.ref <span style="color: grey">(19b8b40)</span></li>
<li>src/kconfig_compiler/kconfig_compiler.cpp <span style="color: grey">(5aae340)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123367/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>