Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79353
-----------------------------------------------------------


If the first issue doesn't fit into this commit, this has a ship it from me after the two nitpicks are fixed.


autotests/kconfig_compiler/test13.h.ref (line 51)
<https://git.reviewboard.kde.org/r/123367/#comment54201>

    This looks better, but I just thought of one other case: when the underlying KConfig class gets updated and the KConfigSkeleton updates.  If that isn't too much work to do here, I'd appreciate it if it's done now.  Otherwise please file a bug against KConfig so I don't forget.



src/kconfig_compiler/kconfig_compiler.cpp (line 1418)
<https://git.reviewboard.kde.org/r/123367/#comment54202>

    Nitpick: Please always include braces on if statements.



src/kconfig_compiler/kconfig_compiler.cpp (line 1452)
<https://git.reviewboard.kde.org/r/123367/#comment54203>

    Nitpick: braces here too.


- Matthew Dawson


On April 22, 2015, 12:07 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123367/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 12:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> The generation of those classes makes it useful to have these being used within C++ application. This change makes it possible to use these classes from QML as well.
> 
> For each variable, exposes the getter. In case there's a setter, it will add a notify signal and the setter to the property.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfig_compiler/CMakeLists.txt 0cca605 
>   autotests/kconfig_compiler/kconfigcompiler_test.cpp 43623ce 
>   autotests/kconfig_compiler/test13.cpp.ref PRE-CREATION 
>   autotests/kconfig_compiler/test13.h.ref PRE-CREATION 
>   autotests/kconfig_compiler/test13.kcfg PRE-CREATION 
>   autotests/kconfig_compiler/test13.kcfgc PRE-CREATION 
>   autotests/kconfig_compiler/test13main.cpp PRE-CREATION 
>   autotests/kconfig_compiler/test_signal.cpp.ref 58e73ef 
>   autotests/kconfig_compiler/test_signal.h.ref 19b8b40 
>   src/kconfig_compiler/kconfig_compiler.cpp 5aae340 
> 
> Diff: https://git.reviewboard.kde.org/r/123367/diff/
> 
> 
> Testing
> -------
> 
> KConfig tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150422/753e3039/attachment-0001.html>