Review Request 123397: Generalize the creation of KPluginLoader-based plugins
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Apr 17 14:53:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123397/
-----------------------------------------------------------
(Updated April 17, 2015, 4:53 p.m.)
Review request for KDE Frameworks and Alex Richardson.
Changes
-------
Introduce an error message if the install path is not specified, as suggested by Milian.
Repository: kcoreaddons
Description
-------
I was about to fork this macro (originally developed for KDevPlatform) for the 2nd time, it was time to put it somewhere where it can be shared.
Basically puts together the different parts of the process so that it's comfortable to develop later on. Especially useful the fact that it makes the JSON file a dependency of the cpp file, so changes are adopted automatically.
Diffs (updated)
-----
KF5CoreAddonsMacros.cmake 7ea72af
Diff: https://git.reviewboard.kde.org/r/123397/diff/
Testing
-------
It's being used already in KDevelop and KDE Connect.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150417/93e9c088/attachment.html>
More information about the Kde-frameworks-devel
mailing list