Review Request 123397: Generalize the creation of KPluginLoader-based plugins

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123397/#review79123
-----------------------------------------------------------


does this error out properly when the install namespace is empty or the list of sources is empty? the latter was recently added to kdevplatform afaik.

as the initial author of this macro in kdev, a general +1 from my side for upstreaming it and many thanks!

- Milian Wolff


On April 17, 2015, 12:35 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123397/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 12:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Richardson.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> I was about to fork this macro (originally developed for KDevPlatform) for the 2nd time, it was time to put it somewhere where it can be shared.
> 
> Basically puts together the different parts of the process so that it's comfortable to develop later on. Especially useful the fact that it makes the JSON file a dependency of the cpp file, so changes are adopted automatically.
> 
> 
> Diffs
> -----
> 
>   KF5CoreAddonsMacros.cmake 7ea72af 
> 
> Diff: https://git.reviewboard.kde.org/r/123397/diff/
> 
> 
> Testing
> -------
> 
> It's being used already in KDevelop and KDE Connect.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150417/85ded634/attachment.html>