Review Request 123397: Generalize the creation of KPluginLoader-based plugins

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123397/#review79131
-----------------------------------------------------------



KF5CoreAddonsMacros.cmake (line 108)
<https://git.reviewboard.kde.org/r/123397/#comment54078>

    I would also grep for Q_PLUGIN_METADATA(IID ... FILE foo.json).
    Also maybe make the macro name customizable. For example okular uses OKULAR_EXPORT_PLUGIN for the plugins (which could probably be replaced by K_PLUGIN_FACTORY_WITH_JSON, but I haven't looked into that yet).


- Alex Richardson


On April 17, 2015, 3:53 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123397/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 3:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Richardson.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> I was about to fork this macro (originally developed for KDevPlatform) for the 2nd time, it was time to put it somewhere where it can be shared.
> 
> Basically puts together the different parts of the process so that it's comfortable to develop later on. Especially useful the fact that it makes the JSON file a dependency of the cpp file, so changes are adopted automatically.
> 
> 
> Diffs
> -----
> 
>   KF5CoreAddonsMacros.cmake 7ea72af 
> 
> Diff: https://git.reviewboard.kde.org/r/123397/diff/
> 
> 
> Testing
> -------
> 
> It's being used already in KDevelop and KDE Connect.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150417/8aa91bbb/attachment.html>