Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120088/#review65958
-----------------------------------------------------------

Ship it!



src/kstandardaction.cpp
<https://git.reviewboard.kde.org/r/120088/#comment46063>

    Well, avoiding a warning is not the actual reason :) The actual reason is to allow the "configure shortcuts" to find out what the default shortcut is, even if the user configured another shortcut.



src/kstandardaction.cpp
<https://git.reviewboard.kde.org/r/120088/#comment46064>

    s/the//


- David Faure


On Sept. 7, 2014, 8:44 a.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120088/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 8:44 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> Fix the 'Shortcut for action  "XXX" "YYY" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead' for StdActions
> 
> 
> Diffs
> -----
> 
>   src/kstandardaction.cpp a18527b 
> 
> Diff: https://git.reviewboard.kde.org/r/120088/diff/
> 
> 
> Testing
> -------
> 
> Standard actions use lead to that warning, as the internally use just setShortcuts (as they can't use KActionCollection).
> KWrite now starts up with close to zero warnings (and none for standard actions, I think).
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140907/3afc952b/attachment.html>