Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

Christoph Cullmann cullmann at kde.org
Sun Sep 7 11:33:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120088/
-----------------------------------------------------------

(Updated Sept. 7, 2014, 11:33 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kconfigwidgets


Description
-------

Fix the 'Shortcut for action  "XXX" "YYY" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead' for StdActions


Diffs
-----

  src/kstandardaction.cpp a18527b 

Diff: https://git.reviewboard.kde.org/r/120088/diff/


Testing
-------

Standard actions use lead to that warning, as the internally use just setShortcuts (as they can't use KActionCollection).
KWrite now starts up with close to zero warnings (and none for standard actions, I think).


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140907/ac9b29fc/attachment.html>


More information about the Kde-frameworks-devel mailing list