Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120088/
-----------------------------------------------------------

(Updated Sept. 7, 2014, 8:44 a.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Missed the showMenu action. Perhaps the same should be done for the setShortcuts call in the AutomaticAction constructor, but now at least kate/kwrite stdactions are really clean of warnings it seems.


Repository: kconfigwidgets


Description
-------

Fix the 'Shortcut for action  "XXX" "YYY" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead' for StdActions


Diffs (updated)
-----

  src/kstandardaction.cpp a18527b 

Diff: https://git.reviewboard.kde.org/r/120088/diff/


Testing
-------

Standard actions use lead to that warning, as the internally use just setShortcuts (as they can't use KActionCollection).
KWrite now starts up with close to zero warnings (and none for standard actions, I think).


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140907/6a6ebaa6/attachment.html>