Review Request 120603: Use officially exported CMAKE paths
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Oct 15 22:48:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120603/#review68528
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 15, 2014, 8:45 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120603/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 8:45 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kauth
>
>
> Description
> -------
>
> Use officially exported CMAKE paths
>
> PLUGIN_INSTALL_DIR is not documented in the header of KDEInstallDirs
>
> More importantly on builds that use KDE_INSTALL_USE_QT_SYS_PATHS this is
> relative, whereas normally it's absolute.
>
> By using the CMAKE_INSTALL_FULL path we avoid that problem as it goes
> through the define_relatve define_absolute macros.
>
>
> Diffs
> -----
>
> src/BackendsConfig.h.cmake 9b82fb8
>
> Diff: https://git.reviewboard.kde.org/r/120603/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141015/19c186e0/attachment.html>
More information about the Kde-frameworks-devel
mailing list