Review Request 120603: Use officially exported CMAKE paths

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120603/#review68523
-----------------------------------------------------------

Ship it!


tnx. maybe KF5AuthMacros.cmake could also be adjusted? currently it evaluates by hand whether KAUTH_HELPER_INSTALL_DIR is relative or absolute

- Hrvoje Senjan


On Oct. 15, 2014, 10:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120603/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 10:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> Use officially exported CMAKE paths
> 
> PLUGIN_INSTALL_DIR is not documented in the header of KDEInstallDirs
> 
> More importantly on builds that use KDE_INSTALL_USE_QT_SYS_PATHS this is
> relative, whereas normally it's absolute.
> 
> By using the CMAKE_INSTALL_FULL path we avoid that problem as it goes
> through the define_relatve define_absolute macros.
> 
> 
> Diffs
> -----
> 
>   src/BackendsConfig.h.cmake 9b82fb8 
> 
> Diff: https://git.reviewboard.kde.org/r/120603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141015/283ae80b/attachment.html>